workspace menu is always in hbar-section, fix #480

[vincent-peugnet]

• remove home specific absolute positioning
• remove unused "hide in case of js" css

@jbidoret : this is how I would do it.

You tell me if it's ok for you ! 😃

I don't see the problem when only the button is display:none. 🤔 maybe because I did'nt checked all the themes!
Anyway, since with this PR, <form> is always inside a hbar-section, it can be hidden without breaking the flex positioning.

[jbidoret]

I understand the way you solved it, but we still have a little problem with it.

What we have with your PR: (Edit view, js ENabled !)

What we want :

The form, not being completely hidden still takes place in the flexbox, leading to this unwanted space at the end of the hbar. There are multiple ways to solve this issue, but we should think about what might be necessary in the future. IM(H)O, a robust way to transmit to the CSS if js is on or off is necessary, as we may want to adapt the layout and styles from within the CSS, and not in JS.

[ edited : js Enabled, not disabled… ]

[vincent-peugnet]

IM(H)O, a robust way to transmit to the CSS if js is on or off is necessary, as we may want to adapt the layout and styles from within the CSS, and not in JS.

Okkk ! I got it ! (sorry I'm long to understand 😄)

but we still have a little problem with it.

I added a commit that hide the full div instead of just the submit button in order to fix this. (The idea was to fix this issue without needing of changing the JS on/off strategy)

If you're ok with this version as quick fix, I merge this and then you can come with your new workflow (if you want) !

[jbidoret]

Cool !