Fix bug where window resizing breaks if a session is launched via twm #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses the issue with gh-16 where resizing the window breaks everything if your tmux session was attached to via execvp. I still have *no* idea why this is happening, but this seems to fix it at least; instead of calling execvp with tmux as the target program, we call it to whatever the user's shell is with `-c tmux attach -t <session_name>` as the arguments. Tested this across multiple shells and it seems to work fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue with gh-16 where resizing the window breaks everything if your tmux session was attached to via execvp.
I still have no idea why this is happening, but this seems to fix it at least; instead of calling execvp with tmux as the target program, we call it to whatever the user's shell is with
-c tmux attach -t <session_name>as the arguments.Tested this across multiple shells and it seems to work fine.