-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3 1 5 backport #37
Open
tanmay3011
wants to merge
36
commits into
3-1-stable
Choose a base branch
from
3-1-5-backport
base: 3-1-stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
3 1 5 backport #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update gem name from spree_reportify to spree_admin_insights
show insights tab only if accessible
…issue Get db config from ActiveRecord::Base.
changes params for Sequel connection(for sqlite db)
Add polish translations
Promotion Analysis Fixes
1. Standardize on report_category instead of using type and category alternatively. 2. Add initializer to configure list of reports to be used. 3. Reduce responsibility of report generation service to just generate reports
For detailed changelog see: #33
1. There was an issue with order dependency while populating the report data back into timed observations, reverting to using a search and fill strategy instead of filling them sequentially.
Shipment may lie in an entirely different time period then that of when the order was completed. The date used for considering an order is it’s completed_at date, Using the same date for calculating shipment ensures that they lie within the expected reporting period.
Closed
3 1 5 backport
Fix content tag for Rails 5.1 and add spree_master and fix minor bugs
Convert result from count query to integer for older version of pg gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.