feat: add kNN search, query support #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestas-vinted
previously approved these changes
Apr 5, 2024
ernestas-vinted
approved these changes
Apr 5, 2024
|
Seems like everything is covered. And in my app, it works as expected. Thanks for adding this 👍 |
|
@DmitrySamoylov cool, I've released 0.4.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the missing kNN support coming from #265.
There are two ways to query nearest vectors in elasticsearch:
They are slightly similar but different at the time, kNN query is considered expert mode, has fewer fields so I kept these objects separate for type-safety.
@DmitrySamoylov do you mind double checking if this is as expected? I went through the documentation and seems like I've covered everything.