Miscellaneous housekeeping #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Ball <[email protected]>
* upgrade to v3 setup workflows * dynamically detect Go version from go.mod * use setup-go step in verify for workflow for consistency Signed-off-by: Mike Ball <[email protected]>
Signed-off-by: Mike Ball <[email protected]>
This seeks to ensure the terraform-provider-vinyldns binaries are properly build on PR verification. This also removes the 'shell: bash' configuration from various workflow steps, as bash is already the default shell in GH Actions. Signed-off-by: Mike Ball <[email protected]>
|
👋 Hi @remerle - are you comfortable approving the workflow run on this PR? There are some additional changes I'd like to layer in -- either in this PR or a follow-on PR -- and CI verification would be very helpful :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hello! This is a
(currently draft)PR to layer in some slight process improvements and to address some deferred maintenance in advance of potentially migratingterraform-provider-vinyldnsto utilize the new plugin framework.