-
Notifications
You must be signed in to change notification settings - Fork 108
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GVR was using the deprecated UIWebView, which was preventing app store submission. Remove GVR entirely from iOS as it’s now deprecated.
- Loading branch information
Showing
13 changed files
with
16 additions
and
1,555 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,16 @@ | ||
PODS: | ||
- GoogleToolboxForMac/Defines (2.1.0) | ||
- GoogleToolboxForMac/Logger (2.1.0): | ||
- GoogleToolboxForMac/Defines (= 2.1.0) | ||
- GTMSessionFetcher/Core (1.1.6) | ||
- GVRAudioSDK (1.120.0) | ||
- GVRKit (1.120.0): | ||
- GVRSDK (= 1.120.0) | ||
- GVRSDK (1.120.0): | ||
- GoogleToolboxForMac/Logger (= 2.1.0) | ||
- GTMSessionFetcher/Core (= 1.1.6) | ||
|
||
DEPENDENCIES: | ||
- GVRAudioSDK (= 1.120.0) | ||
- GVRKit (= 1.120.0) | ||
- GVRSDK (= 1.120.0) | ||
|
||
SPEC REPOS: | ||
https://github.com/cocoapods/specs.git: | ||
- GoogleToolboxForMac | ||
- GTMSessionFetcher | ||
- GVRAudioSDK | ||
- GVRKit | ||
- GVRSDK | ||
|
||
SPEC CHECKSUMS: | ||
GoogleToolboxForMac: 2b2596cbb7186865e98cadf2b1e262d851c2b168 | ||
GTMSessionFetcher: 6aacd0ab48ddf0c3633ab2642d792abfcad1b08a | ||
GVRAudioSDK: 302f0a8f190d855868ea07f246ce4f9b44c392ae | ||
GVRKit: 424e48fafa9f8a6249a14ffda48d2f1dbe3d9def | ||
GVRSDK: 0cb9d0ce06a84d698e61e3db9509766022dcf815 | ||
|
||
PODFILE CHECKSUM: 26ce74a09cf7430dd7c82b2b79c95dfd6159f50c | ||
PODFILE CHECKSUM: 89c2f1709300d1c1cec2b0716b4cb044211565ba | ||
|
||
COCOAPODS: 1.5.3 |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
5501a86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@radvani this works great and ViroKit compiles nicely. Unfortunately the static library does not compile, and it's much easier to use the static library with Viro. I'm on RN 0.62.2 and have Viro static library working great, but App Store is rejecting due to UIWebView.
I'm manually going through trying to get the static library to compile for use with AR - I was able to get this to work, and successfully submitted to Apple, but the quality of my effort is a way lower bar. Details here: viromedia/viro#852 (comment)
Curious if it would be relatively low effort for someone as well versed as you to do the same thing you did for ViroKit to the static library target. Thank you for this amazing project!