-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert from automake to cmake #57
Conversation
Thanks @gianlourbano - please fix the automated tests to replace the build step accordingly (see failed actions). |
Sorry I did not realize this was blocked because the tests did not run. There seems to be still a cmake-related failure on MacOS. |
yes, just updated the ci file, i think it should work now |
Still no luck. There's always some trial and error involved with github actions 😁 |
don't worry, i think i know where the problem is. I'll try on my macbook first |
MacOS test passes now |
Everything should work now. Incredible skill issue on my part, sorry |
🥳 everything works now! Thanks @gianlourbano ! Can you please squash into a single commit, there's a lot of fixups in this tree. |
I think there is a "squash and merge" option when merging, might have to click "try the new merging experience" |
I'd rather do it manually, I'm not sure what the web tool is doing under the hood. I'll take care of this step. I'll merge this ASAP. Thank you! |
Conversion of the build system from automake to cmake.