Fix ONCE
environment variable ignorance
#13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Here's the MR to fix the issue I have faced with
ONCE
environment variable being ignored, when executed via Docker.One important note: this changes
docker-compose-watcher
(or, in fact,compose-updater
) default value ofonce
to false, so that it would be possible to remove-once=0
from Dockerfile, but still keeping the old behavior:The reason of removing this argument from
CMD
above is rather simple: due to code structure command line arguments takes precedence over environment variables, which I think is the right way to go. However, keeping-once=0
will prevent ability to override behavior of passing environment variableONCE
to Docker.Basically, this MR makes everyone happy.
Few other small things irrelevant to original issue comes as a bonus.