Sittun: add Proto field #531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corresponds to the `mode` parameter of the ip link command.
The options are:
mode { ip6ip | ipip | any }
Where:
- any: 0
- ip6ip: IPPROTO_IPV6
- ipip: IPPROTO_IPIP
Signed-off-by: Gregory Detal <[email protected]>
|
Would it be possible to add a simple UT for this ? |
aboch
reviewed
Nov 22, 2020
| @@ -2674,6 +2674,7 @@ func addSittunAttrs(sittun *Sittun, linkInfo *nl.RtAttr) { | |||
| data.AddRtAttr(nl.IFLA_IPTUN_ENCAP_FLAGS, nl.Uint16Attr(sittun.EncapFlags)) | |||
| data.AddRtAttr(nl.IFLA_IPTUN_ENCAP_SPORT, htons(sittun.EncapSport)) | |||
| data.AddRtAttr(nl.IFLA_IPTUN_ENCAP_DPORT, htons(sittun.EncapDport)) | |||
| data.AddRtAttr(nl.IFLA_IPTUN_PROTO, nl.Uint8Attr(sittun.Proto)) | |||
| } | |||
|
|
|||
| func parseSittunData(link Link, data []syscall.NetlinkRouteAttr) { | |||
There was a problem hiding this comment.
Don't we also need to be able to read this field?
There was a problem hiding this comment.
@gdetal Don't we need to also modify parseSittunData() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to the
modeparameter of the ip link command.The options are:
mode { ip6ip | ipip | any }
Where:
Signed-off-by: Gregory Detal [email protected]