Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added v0.1 of mrMeshPy #301

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Added v0.1 of mrMeshPy #301

wants to merge 11 commits into from

Conversation

andregouws
Copy link

This should have minimal impact on the existing stream as the mrMeshPy code is independent
Caveats:

Andre Gouws and others added 10 commits July 25, 2018 16:20
Created a folder and initial README to initiate permissions for addit…
e9abdba 
…ion of mrMeshPy
First commit of mrMeshPy to vistasoft
f8b2a61
Override one for the original mrMesh routines -- shouldn't be an issu…
a873de2 
…e as its no longer used if one is using mrMeshPy?
re-insert the dataOverlay variable into the one origianl routine I ch…
22d49b0 
…anged - lets change as little as possible for anyone still wanting to use mrMesh
removed test data - will provide that as a download link
ea8c761
Alter mrMesh/meshviewer/meshColorOverlay.m original code to retain ba…
ebe9c03 
…ckwards compatibility but add support for mrMeshPy
reverted meshColorOverlay for backwards compatibility; made matlabRou…
9f100ac 
…tines executbale
Added gui launcher for mrMeshPy 3D window
790883a
Couple of extra tweaks to add menu items
1887bc0
Couple of extra tweaks to add menu items
d06eba1
@arokem
Copy link
Member

arokem commented Jul 26, 2018

This looks very cool! A couple of comments/questions from the peanut gallery:

  1. Would it make sense to modularize some of the Python functionality and put it in a separate Python package? I can imagine situations in which people might want to call these functions without Matlab.

  2. I would encourage you to take a look at messaging using 0MQ. It has many advantages. The major drawback is that you might need to compile a mex file for that. You can take a look at pymatbridge for some inspiration (and for pan-platform builds, see here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andregouws @arokem