Skip to content

Commit

Permalink
fixed callback not working on actions with blocking=True
Browse files Browse the repository at this point in the history
  • Loading branch information
visualDust committed Nov 25, 2023
1 parent b9216f5 commit 5649804
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions neetbox/daemon/client/_action_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,21 +77,21 @@ def eval_call(name: str, params: dict, callback: None):
logger.log(
f"Agent runs function '{target_action.name}', blocking = {target_action.blocking}"
)
if not target_action.blocking: # non-blocking run in thread

def run_and_callback(target_action, params, callback):
returned_data = target_action.eval_call(params)
if callback:
callback(returned_data)
def run_and_callback():
returned_data = target_action.eval_call(params)
if callback:
callback(returned_data)

if not target_action.blocking: # non-blocking run in thread
Thread(
target=run_and_callback,
kwargs={"target_action": target_action, "params": params, "callback": callback},
daemon=True,
).start()
return None
return
else: # blocking run
return target_action.eval_call(params)
run_and_callback()
return

@watch(name="__action", initiative=True, _channel=SYSTEM_CHANNEL)
def _update_action_dict():
Expand Down

0 comments on commit 5649804

Please sign in to comment.