-
Notifications
You must be signed in to change notification settings - Fork 71
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add 'not widely supported' SGR to support rate.cx (#39)
- Loading branch information
1 parent
723ca18
commit 65c9680
Showing
2 changed files
with
76 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this sample in the Sample's README in the Samples list.
65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not simply remove that nobody-ever-updated-list ?
65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yne because it explains what each sample do.
For exemple, what's the difference between http-net and http-net-bsd has not be explained yet.
65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to create a README.md in each sample folder.
This way we could have more organised/detailed informations (and screenshot !)
Also, clicking on a folder from github will display the sample README (which is good)
Finally, I could also create a jekyll file, so the sample repo could be browsed from vitasdk.github.io/samples
What do you think ?
65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather have an overview at the root so complexity
O(1)
rather that needing to open each sample folder to figure out what it does which isO(n)
.65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think same as @devnoname120 .
By the way noname120, where did you learned to talk about complexity this way ?
65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devnoname120 Need an overview of every sample ? here you go :
for md in */README.md ; do cat $md; done
BTW current one-liner sample description are laughable:
"A minimal $folder sample."
So yeah, a dedicated README.md would be more useful IMO.
65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github doesn't have a shell interpreter.
65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so how about this one:
Mixing every sample description in one README also increase complexity because if you are looking for a particular one (which is the most common scenario) you need to filter-out the other samples description.
And for elder people, filtering information is very painful so I estimate the complexity to
log2(n)
:)65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about #42 :)
65c9680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the issue instead of discussing about it for hours, thanks! 👍