Add missing definitions for adhoc matching headers #839
Conversation
include/psp2/net/adhoc_matching.h
Outdated
| SCE_NET_ADHOC_MATCHING_HANDLER_EVENT_BYE = 10, | ||
| SCE_NET_ADHOC_MATCHING_HANDLER_EVENT_DATA = 11, | ||
| SCE_NET_ADHOC_MATCHING_HANDLER_EVENT_DATA_ACK = 12, | ||
| SCE_NET_ADHOC_MATCHING_HANDLER_EVENT_DATA_TIMEOUT = 13 |
There was a problem hiding this comment.
- have you get these enums via reversing module by yourself?
- doesn't referenced leaked/official sdk?
There was a problem hiding this comment.
I reversed and re-implemented the full module in Vita3K/Vita3K#3470 although my work is a continuation of another WIP from another user that happens to have this exact enum already. The module behavior does seem to match with the enum names.
Since I can't confirm the source of this enum I can remove it as it's not essential for this header to work properly.
There was a problem hiding this comment.
yep. please remove them and keep only your own reversing part. we cannot allow official sdk part. unknown source has same risk.
There was a problem hiding this comment.
@german77 sorry. something mores.
- are remain enums safe?
- please match code convention
- use hardtab for indentation
- if you doesn't have special reason, please use
snake_casefor structure field & function arguments (code coventions)- for example;
optLento beopt_len
- for example;
@Princess-of-Sleeping can you support this review if I late :'(
There was a problem hiding this comment.
Remaining enums are safe. I did the rest of this header by myself and I also have an usage example that I will upstream once this is merged. I will address the formatting issues in the following minutes.
There was a problem hiding this comment.
Just as a side note the files in the same folder as this one don't match the convention.
german77
force-pushed
the
adhoc
branch
2 times, most recently
from
943fbc5 to
c5a62e1
Compare
|
ah you should define doc group in here |
|
ty for your contribution & patient :) |
No description provided.