-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VFS library #840
Add VFS library #840
Conversation
a57211d
to
73dc67f
Compare
Add header for Iofilemgr VFS functionality. Enables the implementing of custom file system drivers. Co-Authored-By: Princess-of-Sleeping <[email protected]>
include/psp2kern/vfs.h
Outdated
* VFS Info defining a VFS Implementation | ||
*/ | ||
typedef struct SceVfsInfo { | ||
SceVfsOpTable *vfsOps; //!< VFS Implementation operations for mountpoint actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change these member names to snake_case
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as all structures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I can do it, as I understand it's for consistency reasons in the SDK, right? The current camelCase is derived from debug strings referencing the fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. i know. couple years ago, princess was also explained that.
it just sdk naming reason :)
include/psp2kern/vfs.h
Outdated
SceVfsMount *mnt; | ||
const char *dev; | ||
unsigned int cmd; | ||
const void *arg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mixed indent type
i don't remember we use hardtab or softtab in future files.
@Princess-of-Sleeping do you remember this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll use hardtabs ('\t' characters) since sdstor.h, the most recently added header, does the same.
include/psp2kern/vfs.h
Outdated
* directory which has been looked-up or accessed. | ||
*/ | ||
typedef struct SceVfsVnode { | ||
struct { // vdlock? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we give a name this and below structure?
Add header for Iofilemgr VFS functionality. Enables the implementing of custom file system drivers.
Argument structures derived from vita-header-internal. Credit @Princess-of-Sleeping