Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VFS library #840

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Add VFS library #840

merged 2 commits into from
Jan 3, 2025

Conversation

bythos14
Copy link
Contributor

@bythos14 bythos14 commented Jan 2, 2025

Add header for Iofilemgr VFS functionality. Enables the implementing of custom file system drivers.

Argument structures derived from vita-header-internal. Credit @Princess-of-Sleeping

@bythos14 bythos14 force-pushed the vfs branch 4 times, most recently from a57211d to 73dc67f Compare January 2, 2025 04:17
Add header for Iofilemgr VFS functionality. Enables the implementing of custom file system drivers.

Co-Authored-By: Princess-of-Sleeping <[email protected]>
* VFS Info defining a VFS Implementation
*/
typedef struct SceVfsInfo {
SceVfsOpTable *vfsOps; //!< VFS Implementation operations for mountpoint actions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change these member names to snake_case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as all structures

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I can do it, as I understand it's for consistency reasons in the SDK, right? The current camelCase is derived from debug strings referencing the fields.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. i know. couple years ago, princess was also explained that.

it just sdk naming reason :)

SceVfsMount *mnt;
const char *dev;
unsigned int cmd;
const void *arg;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixed indent type

i don't remember we use hardtab or softtab in future files.
@Princess-of-Sleeping do you remember this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll use hardtabs ('\t' characters) since sdstor.h, the most recently added header, does the same.

* directory which has been looked-up or accessed.
*/
typedef struct SceVfsVnode {
struct { // vdlock?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we give a name this and below structure?

@bythos14 bythos14 requested a review from d3m3vilurr January 2, 2025 22:18
@d3m3vilurr d3m3vilurr merged commit f1f2610 into vitasdk:master Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants