fix(ssr): fix transform error due to export all id scope #19331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
export * as variable from "./somefile"
andimport * as variable from "./somefile"
in same file with vite v6 #19329export * as variable from "./somefile"
andimport * as variable from "./somefile"
in same file with vite v6 vitest-dev/vitest#7394Even on Vite 5, SSR transform wasn't properly handling the identifier from
export * as id from ".."
as seen by the same repro https://stackblitz.com/edit/github-pnyojxdr-mena4fdt?file=repro-vite.jsI haven't investigated why this now causes magic-string error, but this can be fixed by fixing
isRefIdentifier
to skip identifiers insideexport * ...
.