rename

Signed-off-by: Tim Vaillancourt <[email protected]>

go/flags/endtoend/vtorc.txt

@@ -32,7 +32,7 @@ Flags:
       --config-persistence-min-interval duration                    minimum interval between persisting dynamic config changes back to disk (if no change has occurred, nothing is done). (default 1s)
       --config-type string                                          Config file type (omit to infer config type from file extension).
       --consul_auth_static_file string                              JSON File to read the topos/tokens from.
-      --discovery-max-concurrency int                               Number of workers used for tablet discovery (default 300)
+      --discovery-workers int                                       Number of workers used for tablet discovery (default 300)
       --emit_stats                                                  If set, emit stats to push-based monitoring and stats backends
       --enable-primary-disk-stalled-recovery                        Whether VTOrc should detect a stalled disk on the primary and failover
       --grpc-dial-concurrency-limit int                             Maximum concurrency of grpc dial operations. This should be less than the golang max thread limit of 10000. (default 1024)

go/vt/vtorc/config/config.go

@@ -57,10 +57,10 @@ var (
 		},
 	)
 
-	discoveryMaxConcurrency = viperutil.Configure(
-		"discovery-max-concurrency",
+	discoveryWorkers = viperutil.Configure(
+		"discovery-workers",
 		viperutil.Options[int]{
-			FlagName: "discovery-max-concurrency",
+			FlagName: "discovery-workers",
 			Default:  300,
 			Dynamic:  false,
 		},
@@ -199,7 +199,7 @@ func init() {
 
 // registerFlags registers the flags required by VTOrc
 func registerFlags(fs *pflag.FlagSet) {
-	fs.Int("discovery-max-concurrency", discoveryMaxConcurrency.Default(), "Number of workers used for tablet discovery")
+	fs.Int("discovery-workers", discoveryWorkers.Default(), "Number of workers used for tablet discovery")
 	fs.String("sqlite-data-file", sqliteDataFile.Default(), "SQLite Datafile to use as VTOrc's database")
 	fs.Duration("instance-poll-time", instancePollTime.Default(), "Timer duration on which VTOrc refreshes MySQL information")
 	fs.Duration("snapshot-topology-interval", snapshotTopologyInterval.Default(), "Timer duration on which VTOrc takes a snapshot of the current MySQL information it has in the database. Should be in multiple of hours")
@@ -220,7 +220,7 @@ func registerFlags(fs *pflag.FlagSet) {
 	viperutil.BindFlags(fs,
 		instancePollTime,
 		preventCrossCellFailover,
-		discoveryMaxConcurrency,
+		discoveryWorkers,
 		sqliteDataFile,
 		snapshotTopologyInterval,
 		reasonableReplicationLag,
@@ -258,9 +258,9 @@ func GetPreventCrossCellFailover() bool {
 	return preventCrossCellFailover.Get()
 }
 
-// GetDiscoveryMaxConcurrency is a getter function.
-func GetDiscoveryMaxConcurrency() uint {
-	return uint(discoveryMaxConcurrency.Get())
+// GetDiscoveryWorkers is a getter function.
+func GetDiscoveryWorkers() uint {
+	return uint(discoveryWorkers.Get())
 }
 
 // GetSQLiteDataFile is a getter function.

go/vt/vtorc/logic/vtorc.go

@@ -110,7 +110,7 @@ func waitForLocksRelease() {
 func handleDiscoveryRequests() {
 	discoveryQueue = discovery.NewQueue()
 	// create a pool of discovery workers
-	for i := uint(0); i < config.GetDiscoveryMaxConcurrency(); i++ {
+	for i := uint(0); i < config.GetDiscoveryWorkers(); i++ {
 		go func() {
 			for {
 				tabletAlias := discoveryQueue.Consume()