test: update test expectations

Signed-off-by: Andres Taylor <[email protected]>
vitessio · Feb 28, 2025 · d901232 · d901232
1 parent 5033886
commit d901232
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/go/tools/asthelpergen/integration/integration_rewriter_test.go b/go/tools/asthelpergen/integration/integration_rewriter_test.go
@@ -382,8 +382,8 @@ func TestVisitableRewrite(t *testing.T) {
 		Pre{visitable},
 		Pre{leaf},
 		Post{leaf},
-		Pre{visitable},
-		Pre{refContainer},
+		Post{visitable},
+		Post{refContainer},
 	})
 }
 
@@ -418,6 +418,7 @@ func (tv *rewriteTestVisitor) post(cursor *Cursor) bool {
 	return true
 }
 func (tv *rewriteTestVisitor) assertEquals(t *testing.T, expected []step) {
+	t.Helper()
 	assertStepsEqual(t, tv.walk, expected)
 }
 

diff --git a/go/vt/sqlparser/rewriter_api.go b/go/vt/sqlparser/rewriter_api.go
@@ -113,6 +113,8 @@ type Cursor struct {
 	current *pathbuilder.ASTPathBuilder
 }
 
+// Visitable is the interface that needs to be implemented by all nodes that live outside the `sqlparser` package,
+// in order to visit/rewrite/copy_on_rewrite these nodes.
 type Visitable interface {
 	SQLNode
 	VisitThis() SQLNode