Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return SourceAlias in FullStatus RPC, use to optimize VTOrc #17843

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

more cases

1b3970f
Select commit
Loading
Failed to load commit list.
Open

Return SourceAlias in FullStatus RPC, use to optimize VTOrc #17843

more cases
1b3970f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 21, 2025 in 1s

67.44% (+0.00%) compared to 22988df

View this Pull Request on Codecov

67.44% (+0.00%) compared to 22988df

Details

Codecov Report

Attention: Patch coverage is 6.00000% with 47 lines in your changes missing coverage. Please review.

Project coverage is 67.44%. Comparing base (22988df) to head (1b3970f).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/tabletmanager/rpc_replication.go 0.00% 28 Missing ⚠️
go/vt/vtorc/inst/instance_dao.go 13.63% 19 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17843   +/-   ##
=======================================
  Coverage   67.44%   67.44%           
=======================================
  Files        1592     1592           
  Lines      258173   258252   +79     
=======================================
+ Hits       174126   174189   +63     
- Misses      84047    84063   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.