-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL: consider UUID throttle ratios in user_throttle_ratio
#17850
Merged
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:onlineddl-user-throttler-ratio
Feb 25, 2025
Merged
Online DDL: consider UUID throttle ratios in user_throttle_ratio
#17850
shlomi-noach
merged 2 commits into
vitessio:main
from
planetscale:onlineddl-user-throttler-ratio
Feb 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
…hat and online-ddl ratio Signed-off-by: Shlomi Noach <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17850 +/- ##
==========================================
+ Coverage 67.44% 67.46% +0.01%
==========================================
Files 1592 1592
Lines 258205 258222 +17
==========================================
+ Hits 174151 174211 +60
+ Misses 84054 84011 -43 ☔ View full report in Codecov by Sentry. |
notfelineit
approved these changes
Feb 24, 2025
user_throttle_ratio
user_throttle_ratio
mattlord
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Online DDL
Online DDL (vitess/native/gh-ost/pt-osc)
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #17849 for details.
The online DDL executor checks the throttle ration for each migration;'s UUID and updates
user_throttle_ratio
with the hihest ratio of (uuid-ratio, online-ddl ratio).Related Issue(s)
Fixes #17849
Checklist
Deployment Notes