Adapt to removal of domains from DSLs #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
remove-domains-from-dsls
branch
from
a330774
to
38ba21e
Compare
JanWittler
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Looks fine.
In the Reactions and Mappings, metamodels get a lowercased name while in the Commonalities, they get an uppercased (import "http://abc" as abc / Abc). I guess this was done to avoid further modifications in the files.
Though they are different languages, it might be worth to unify styles in a later pull request.
|
Yes, that's an "inconsistency". Thanks for the hint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the Reactions and Commonalities implementations referring to metamodels instead of domains as changed in vitruv-tools/Vitruv#502.