Remove TUIDs #428
Merged
Remove TUIDs #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeikoKlare
force-pushed
the
remove-tuids
branch
2 times, most recently
from
16e7a39
to
2bc2547
Compare
jGleitz
reviewed
Feb 19, 2021
...ondence/src/tools/vitruv/framework/correspondence/impl/InternalCorrespondenceModelImpl.xtend
Show resolved
Hide resolved
jGleitz
reviewed
Feb 19, 2021
...mework/tools.vitruv.framework.vsum.tests/src/tools/vitruv/framework/tests/vsum/VsumTest.java
Outdated
Show resolved
Hide resolved
jGleitz
reviewed
Feb 19, 2021
bundles/testutils/tools.vitruv.testutils/src/tools/vitruv/testutils/TestLogging.xtend
Outdated
Show resolved
Hide resolved
jGleitz
reviewed
Feb 19, 2021
...ondence/src/tools/vitruv/framework/correspondence/impl/InternalCorrespondenceModelImpl.xtend
Outdated
Show resolved
Hide resolved
jGleitz
reviewed
Feb 19, 2021
...ondence/src/tools/vitruv/framework/correspondence/impl/InternalCorrespondenceModelImpl.xtend
Outdated
Show resolved
Hide resolved
jGleitz
reviewed
Feb 19, 2021
...ondence/src/tools/vitruv/framework/correspondence/impl/InternalCorrespondenceModelImpl.xtend
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
remove-tuids
branch
from
bf273cb
to
a0406d4
Compare
Co-authored-by: Joshua Gleitze <[email protected]>
HeikoKlare
force-pushed
the
remove-tuids
branch
from
a0406d4
to
94b8c88
Compare
jGleitz
reviewed
Feb 23, 2021
bundles/testutils/tools.vitruv.testutils/src/tools/vitruv/testutils/TestLogging.xtend
Show resolved
Hide resolved
|
I wanted to wait until the downstream projects are prepared for this PR. But since vitruv-tools/Vitruv-CaseStudies#131 is failing anyway and I do not know why, I will merge this PR and see whether that magically fixes that problem and otherwise investigate it with the changes in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes TUIDs and completely moves to UUIDs.
tools.vitruv.framework.tuidprojectTuidAwareVitruvDomainand all other domain-specific logic related to TUIDs. Cleans up theAbstractVitruvDomainimplementation, which also contained further logic only necessary for TUIDs.InternalCorrespondenceModelImplcontained a bunch of functionality for TUID handling, which is completely removed.InternalCorrespondenceModelImpl, which bloated up the code.tools.vitruv.framework.util, which were only used by TUID mechanism. Additionally, move tests from this project to a separate test projects and cleanup the dependencies.Fixes #55 (or makes it obsolete).
Fixes #61 (or makes it obsolete).
Fixes #114 (or makes it obsolete).
Fixes #156.