Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error in case home source directory is not accessible #488

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

litvinovg
Copy link
Contributor

What does this pull request do?

Added custom exception in case home source directory doesn't exist (could happen in case tomcat application redeployment fails).

How should this be tested?

  • Build and install VIVO
  • Manually delete directory tomcat/webapps/${app-name}/WEB-INF/resources/home-files
  • Restart tomcat
  • Open VIVO
  • You should see error report containing error description and instruction how to solve the issue.
  • Follow instructions and check if that fixed the issue.

Interested parties

@brianjlowe @chenejac

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. Java

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg works for me. Thanks for this improvement.

Copy link
Member

@brianjlowe brianjlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@brianjlowe brianjlowe merged commit 3f1b01b into vivo-project:main Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants