Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgen: fix codegen for generated tmp var to fit number of indirections from fn argument #22752

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions vlib/v/gen/c/fn.v
Original file line number Diff line number Diff line change
Expand Up @@ -2740,6 +2740,23 @@ fn (mut g Gen) keep_alive_call_postgen(node ast.CallExpr, tmp_cnt_save int) {
}
}

// gen_tmp_var_indirections generates tmp var to fit the expected indirection number
fn (mut g Gen) gen_tmp_var_indirections(var_typ ast.Type, var ast.Ident, nindirections int) {
mut last_var := g.expr_string(var)
var_styp := g.styp(var_typ)
line := g.go_before_last_stmt().trim_space()
g.empty_line = true
tmp_var := g.new_tmp_var()
for i in 0 .. nindirections {
ptr := '*'.repeat(i)
tmp_var_v := if i == 0 { tmp_var } else { '${tmp_var}_${i}' }
g.writeln('${var_styp} *${ptr}${tmp_var_v} = &${last_var};')
last_var = tmp_var_v
}
g.write(line)
g.write(last_var)
}

@[inline]
fn (mut g Gen) ref_or_deref_arg(arg ast.CallArg, expected_type ast.Type, lang ast.Language, is_smartcast bool) {
arg_typ := if arg.expr is ast.ComptimeSelector {
Expand Down Expand Up @@ -2818,6 +2835,12 @@ fn (mut g Gen) ref_or_deref_arg(arg ast.CallArg, expected_type ast.Type, lang as
} else if !(!arg.is_mut && arg_sym.kind == .alias
&& g.table.unaliased_type(arg_typ).is_any_kind_of_pointer()) {
g.write('(voidptr)&/*qq*/')
if arg.expr is ast.Ident && arg.expr.kind != .constant
&& expected_type.nr_muls() > (arg_typ.nr_muls() + 1) {
// generates temporary vars for fit the expected indirections
g.gen_tmp_var_indirections(arg_typ, arg.expr, expected_type.nr_muls() - arg_typ.nr_muls() - 1)
return
}
}
} else {
mut atype := expected_deref_type
Expand Down
12 changes: 12 additions & 0 deletions vlib/v/tests/fns/diff_indirections_arg_test.v
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
fn takes_ref(x &&&&int) {
unsafe {
****x = 5
}
}

fn test_main() {
y := 4
takes_ref(y)
println(y)
assert y == 5
}
Loading