v: fix redundant emission of left expression in in infix expressions #22763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue addressed in #22758. It prevents the left expression of an
in
infix expression from being emitted multiple times. This occurs in the following code example:This gets optimized into:
In this case this optimization is incorrect.
The fix I implemented checks if the left expression is an
ast.Ident
. However, I'm unsure if there is side effect information present in the compiler. Having this information available would allow this optimization to be applied in more situations.Huly®: V_0.6-21210