Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Fix Deepseek V2 fp8 kv-scale remapping #11947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Concurrensee
Copy link

@Concurrensee Concurrensee commented Jan 11, 2025

This PR fix kv-scale remapping for fp8

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Concurrensee Concurrensee force-pushed the deepseek_v2_fp8_remapping branch from cdc303b to 89b6687 Compare January 11, 2025 01:59
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 12, 2025 02:25
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 12, 2025
@DarkLight1337 DarkLight1337 changed the title [Misc] Fix Deepsek V2 fp8 kv-scale remapping [Misc] Fix Deepseek V2 fp8 kv-scale remapping Jan 12, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 12, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants