Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1][Core] Add guided decoding in v1 #11955

Closed
wants to merge 1 commit into from

Conversation

WangErXiao
Copy link
Contributor

Add guided decoding in v1,implemented according to the logic of version v0

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@WangErXiao WangErXiao force-pushed the v1-guided-decoding branch 14 times, most recently from 0df3ffc to cde5a6c Compare January 12, 2025 14:21
@mgoin
Copy link
Member

mgoin commented Jan 12, 2025

Hi @WangErXiao thank you for your pass at this. We have an RFC and new design for guided decoding in V1 that we have detailed here #11908. We are hoping to move the guided decoding backend and FSM into the scheduler to better facilitate future optimizations (like jump decoding) and to reduce duplicated work i.e. each model runner process needing their own FSM. Please join the developer slack channel #feat-structured-output to discuss with us if you are interested in implementation

@WangErXiao
Copy link
Contributor Author

Hi @WangErXiao thank you for your pass at this. We have an RFC and new design for guided decoding in V1 that we have detailed here #11908. We are hoping to move the guided decoding backend and FSM into the scheduler to better facilitate future optimizations (like jump decoding) and to reduce duplicated work i.e. each model runner process needing their own FSM. Please join the developer slack channel #feat-structured-output to discuss with us if you are interested in implementation

OK, looking forward to the new implementation.

@WangErXiao WangErXiao closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants