This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Remove TraceReader trait.
#203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TraceReader` only defined a single method, `map_batches`. Work on persistent traces showed that this is not a good design, as it exposes the internal structure of the trace. We only used this API in one place in `distinct.rs`, and that code would have to be re-written anyway as we generalize `distinct` to work in arbitrary nested scopes. We eliminate the `map_batches` method from the public API and downgrade it to a private method of `Spine`. We also remove the no longer useful trait `TraceReader`.
mihaibudiu
approved these changes
Oct 10, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #203 +/- ##
==========================================
- Coverage 83.40% 83.40% -0.01%
==========================================
Files 126 126
Lines 23482 23468 -14
==========================================
- Hits 19585 19573 -12
+ Misses 3897 3895 -2
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceReaderonly defined a single method,map_batches. Work on persistent traces showed that this is not a good design, as it exposes the internal structure of the trace. We only used this API in one place indistinct.rs, and that code would have to be re-written anyway as we generalizedistinctto work in arbitrary nested scopes.We eliminate the
map_batchesmethod from the public API and downgrade it to a private method ofSpine. We also remove the no longer useful traitTraceReader.Addresses a TODO in PR #124.