Add Initial support for CAPG Provider #243
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jayunit100
I have tested this feature and it works.
I noticed some other gaps in both crashd and CAPG.
crashd potential improvements:
ssh in general needs a rethink
jump_user
should be assumed to be the same as username when not provided. In GCP, that is a very accurate assumption.private_key_path
is set to~/.ssh/id_rsa
which isn't great. by default it should be nullssh_config.go
kubeconfig loading is a bit sketchy
Now, we assume the default context at $KUBECONFIG is the management cluster and the workload cluster config is pulled out by effectively running
clusterctl get kubeconfig NAME
and then using that kubeconfig to talk to the workload cluster. This is not true unfortunately and I have to specify a kubeconfig path.CAPG comments
CAPG manifest
crashd run with CAPG cluster