Skip to content

Commit

Permalink
Fix style for several Access URLs (#2072)
Browse files Browse the repository at this point in the history 
* Fix style for several Access URLs

* Fix snapshots
  • Loading branch information
Andres Martinez Gotor authored Sep 28, 2020
1 parent 0196432 commit 0dc65a2
Show file tree
Hide file tree
Showing 3 changed files with 102 additions and 60 deletions.
8 changes: 5 additions & 3 deletions dashboard/src/components/AppView/AccessURLTable/AccessURLTable.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,11 @@ function flattenIngresses(ingresses: Array<IKubeItem<IResource | IK8sList<IResou

function getAnchors(URLs: string[]) {
return URLs.map(URL => (
<a href={URL} target="_blank" rel="noopener noreferrer" key={URL}>
{URL}
</a>
<div className="margin-b-sm">
<a href={URL} target="_blank" rel="noopener noreferrer" key={URL}>
{URL}
</a>
</div>
));
}

Expand Down
150 changes: 93 additions & 57 deletions dashboard/src/components/AppView/AccessURLTable/__snapshots__/AccessURLTable.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,17 @@ exports[`when the app contains ingresses should show the table with available in
</span>,
"type": "Ingress",
"url": Array [
<a
href="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
<div
className="margin-b-sm"
>
http://foo.bar/ready
</a>,
<a
href="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
>
http://foo.bar/ready
</a>
</div>,
],
},
]
Expand Down Expand Up @@ -214,13 +218,17 @@ exports[`when the app contains ingresses should show the table with available in
</span>,
"type": "Ingress",
"url": Array [
<a
href="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
<div
className="margin-b-sm"
>
http://foo.bar/ready
</a>,
<a
href="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
>
http://foo.bar/ready
</a>
</div>,
],
}
}
Expand All @@ -230,14 +238,18 @@ exports[`when the app contains ingresses should show the table with available in
className=""
key="0-url"
>
<a
href="http://foo.bar/ready"
key="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
<div
className="margin-b-sm"
>
http://foo.bar/ready
</a>
<a
href="http://foo.bar/ready"
key="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
>
http://foo.bar/ready
</a>
</div>
</td>
<td
className=""
Expand Down Expand Up @@ -674,13 +686,17 @@ exports[`when the app contains services and ingresses should show the table with
</span>,
"type": "Service LoadBalancer",
"url": Array [
<a
href="http://1.2.3.4:8080"
rel="noopener noreferrer"
target="_blank"
<div
className="margin-b-sm"
>
http://1.2.3.4:8080
</a>,
<a
href="http://1.2.3.4:8080"
rel="noopener noreferrer"
target="_blank"
>
http://1.2.3.4:8080
</a>
</div>,
],
},
Object {
Expand Down Expand Up @@ -711,13 +727,17 @@ exports[`when the app contains services and ingresses should show the table with
</span>,
"type": "Ingress",
"url": Array [
<a
href="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
<div
className="margin-b-sm"
>
http://foo.bar/ready
</a>,
<a
href="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
>
http://foo.bar/ready
</a>
</div>,
],
},
]
Expand Down Expand Up @@ -779,13 +799,17 @@ exports[`when the app contains services and ingresses should show the table with
</span>,
"type": "Service LoadBalancer",
"url": Array [
<a
href="http://1.2.3.4:8080"
rel="noopener noreferrer"
target="_blank"
<div
className="margin-b-sm"
>
http://1.2.3.4:8080
</a>,
<a
href="http://1.2.3.4:8080"
rel="noopener noreferrer"
target="_blank"
>
http://1.2.3.4:8080
</a>
</div>,
],
}
}
Expand All @@ -795,14 +819,18 @@ exports[`when the app contains services and ingresses should show the table with
className=""
key="0-url"
>
<a
href="http://1.2.3.4:8080"
key="http://1.2.3.4:8080"
rel="noopener noreferrer"
target="_blank"
<div
className="margin-b-sm"
>
http://1.2.3.4:8080
</a>
<a
href="http://1.2.3.4:8080"
key="http://1.2.3.4:8080"
rel="noopener noreferrer"
target="_blank"
>
http://1.2.3.4:8080
</a>
</div>
</td>
<td
className=""
Expand Down Expand Up @@ -869,13 +897,17 @@ exports[`when the app contains services and ingresses should show the table with
</span>,
"type": "Ingress",
"url": Array [
<a
href="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
<div
className="margin-b-sm"
>
http://foo.bar/ready
</a>,
<a
href="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
>
http://foo.bar/ready
</a>
</div>,
],
}
}
Expand All @@ -885,14 +917,18 @@ exports[`when the app contains services and ingresses should show the table with
className=""
key="1-url"
>
<a
href="http://foo.bar/ready"
key="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
<div
className="margin-b-sm"
>
http://foo.bar/ready
</a>
<a
href="http://foo.bar/ready"
key="http://foo.bar/ready"
rel="noopener noreferrer"
target="_blank"
>
http://foo.bar/ready
</a>
</div>
</td>
<td
className=""
Expand Down
4 changes: 4 additions & 0 deletions dashboard/src/components/Layout/Layout.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -197,3 +197,7 @@
cursor: pointer;
}
}

.margin-b-sm {
margin-bottom: 0.3rem;
}

0 comments on commit 0dc65a2

Please sign in to comment.