Bump dependencies and lint #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinniped-dev canceled.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2052 +/- ##
=======================================
Coverage 31.13% 31.13%
=======================================
Files 368 368
Lines 60958 60971 +13
=======================================
+ Hits 18979 18985 +6
- Misses 41455 41461 +6
- Partials 524 525 +1 ☔ View full report in Codecov by Sentry. |
joshuatcasey
force-pushed
the
jtc/bump-all
branch
4 times, most recently
from
6d6a543
to
209b932
Compare
joshuatcasey
force-pushed
the
jtc/bump-all
branch
from
209b932
to
c0b90ad
Compare
… decide where to port-forward
joshuatcasey
force-pushed
the
jtc/bump-all
branch
from
c0b90ad
to
72fa369
Compare
This was referenced Sep 5, 2024
Closed
joshuatcasey
commented
Sep 6, 2024
| @@ -298,53 +303,26 @@ func TestWhoAmI_CSR_Parallel(t *testing.T) { | |||
| ) | |||
| require.NoError(t, err) | |||
|
|
|||
| useCertificatesV1API := testutil.KubeServerSupportsCertificatesV1API(t, kubeClient.Discovery()) | |||
There was a problem hiding this comment.
All supported K8s versions use v1 instead of v1beta
joshuatcasey
commented
Sep 6, 2024
| @@ -353,10 +331,19 @@ func TestWhoAmI_CSR_Parallel(t *testing.T) { | |||
| csrConfig.CertData = crtPEM | |||
| csrConfig.KeyData = keyPEM | |||
|
|
|||
| bytesToHexOfSHA256 := func(b []byte) string { | |||
There was a problem hiding this comment.
this is extra output, I can remove in the next PR
joshuatcasey
commented
Sep 6, 2024
| sha256OfDER := fmt.Sprintf("X509SHA256=%s", bytesToHexOfSHA256(block.Bytes)) | ||
|
|
||
| extra = map[string]identityv1alpha1.ExtraValue{ | ||
| "authentication.kubernetes.io/credential-id": []string{sha256OfDER}, |
There was a problem hiding this comment.
See kubernetes/kubernetes#125634 for the explanation of why this new field exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump dependencies and lint