🐛 Avoid needlessly VC client logout when creds haven't changed #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanv
force-pushed
the
bryanv/dont-vcclient-logout-at-startup
branch
from
3136597 to
e5bb478
Compare
dougm
approved these changes
Feb 5, 2025
bryanv
force-pushed
the
bryanv/dont-vcclient-logout-at-startup
branch
from
e5bb478 to
b857be0
Compare
akutz
approved these changes
Feb 10, 2025
bryanv
force-pushed
the
bryanv/dont-vcclient-logout-at-startup
branch
from
b857be0 to
e8bf34d
Compare
Only logout an existing VC client when the creds have actually changed. Previously, when the Infra Secret controller first starts it would have always logged the VC client if present. While this race has been present for a long time, the addition of the VM Watcher Service made this more likely now since that will usually create a VC client before the Infra secret has started. Move the VC creds secret into a config param. Previously, the Infra Secret controller was hardcoding the secret name, while we'd otherwise obtain the name from the VMOP ConfigMap. This secret name hasn't changed since day 1 so just move it into our config. In the fake VM provider, add gets of the config from the context since we now expect and require the config to be there.
bryanv
force-pushed
the
bryanv/dont-vcclient-logout-at-startup
branch
from
e8bf34d to
8b7d9aa
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Only logout an existing VC client when the creds have actually changed. Previously, when the Infra Secret controller first starts it would have always logged the VC client if present. While this race has been present for a long time, the addition of the VM Watcher Service made this more likely now since that will usually create a VC client before the Infra secret has started.
Move the VC creds secret into a config param. Previously, the Infra Secret controller was hardcoding the secret name, while we'd otherwise obtain the name from the VMOP ConfigMap. This secret name hasn't changed since day 1 so just move it into our config.
In the fake VM provider, add gets of the config from the context since we now expect and require the config to be there.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Effectively deprecating the VcCredsSecretName is what @akutz and I settled on for this
Please add a release note if necessary: