Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling in MsgLoadCatalog #677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vangyzen
Copy link

g_io_channel_read_line returns an error status in addition to setting its GError output parameter. Check both for errors.

g_io_channel_read_line returns an error status in addition to setting
its GError output parameter.  Check both for errors.
@vmwclabot
Copy link
Member

@vangyzen, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@vangyzen, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@vangyzen, VMware has approved your signed contributor license agreement.

@vangyzen
Copy link
Author

This fixes a SIGSEGV on line 518. The line, len, and term variables were clearly uninitialized; they looked like stack addresses. Reading the code for g_io_channel_read_line clearly shows that it can return an error status without touching its output parameters. Unfortunately, I don't know the state of the file system at the time of the crash, so I can't reproduce this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants