Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: errcheck #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: errcheck #54

wants to merge 1 commit into from

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Jan 22, 2025

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Technical Debt: errcheck

Check the return value to ensure that any issues are caught and handled appropriately.

  • hcx/activation.go: Added error handling for JSON encoding in PostActivate and DeleteActivate functions. [1] [2]
  • hcx/certificate.go: Added error handling for JSON encoding in InsertCertificate function.
  • hcx/client.go: Added error handling for XML unmarshalling in HcxConnectorAuthenticate function.
  • hcx/compute_profile.go: Added error handling for JSON encoding in InsertComputeProfile function.
  • hcx/l2_extension.go: Added error handling for JSON encoding in InsertL2Extension function.
  • hcx/location.go: Added error handling for JSON encoding in SetLocation function.
  • hcx/network_profile.go: Added error handling for JSON encoding in various functions such as InsertNetworkProfile, GetNetworkProfile, GetNetworkProfileById, and UpdateNetworkProfile. [1] [2] [3] [4]
  • hcx/role_mapping.go: Added error handling for JSON encoding in PutRoleMapping function.
  • hcx/service_mesh.go: Added error handling for JSON encoding in InsertServiceMesh function.
  • hcx/site_pairing.go: Added error handling for JSON encoding in InsertSitePairing function.
  • hcx/sso.go: Added error handling for JSON encoding in InsertSSO and UpdateSSO functions. [1] [2]
  • hcx/utils.go: Added error handling for JSON encoding in various utility functions such as GetLocalContainer, GetRemoteContainer, GetNetworkBacking, GetVcDatastore, GetVcDvs, GetRemoteCloudList, GetLocalCloudList, GetAppliance, and GetAppliances. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • hcx/vcenter.go: Added error handling for JSON encoding in InsertvCenter function.
  • hcx/vmc.go: Added error handling for JSON encoding in HcxCloudAuthenticate function.
  • resource_compute_profile.go: Added error handling for JSON encoding in resourceComputeProfileCreate function.
  • resource_l2_extension.go: Added error handling for JSON encoding in resourceL2ExtensionCreate function.
  • resource_service_mesh.go: Added error handling for JSON encoding in resourceServiceMeshCreate function.
  • resource_sso.go: Added error handling for DeleteSSO function.
  • resource_vcenter.go: Added error handling for AppEngineStop, AppEngineStart, and DeletevCenter functions in resourcevCenterCreate and resourcevCenterDelete functions. [1] [2] [3]

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Ref: #42

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the chore Chore label Jan 22, 2025
@tenthirtyam tenthirtyam added this to the .next milestone Jan 22, 2025
@tenthirtyam tenthirtyam self-assigned this Jan 22, 2025
@github-actions github-actions bot added the needs-review Needs Review label Jan 22, 2025
@tenthirtyam tenthirtyam marked this pull request as ready for review January 22, 2025 17:07
@tenthirtyam tenthirtyam linked an issue Jan 22, 2025 that may be closed by this pull request
@tenthirtyam tenthirtyam added the technical-debt Technical Debt label Jan 22, 2025
@tenthirtyam tenthirtyam force-pushed the chore/errcheck branch 2 times, most recently from f503509 to 35e4d4d Compare January 23, 2025 22:25
@tenthirtyam tenthirtyam marked this pull request as draft January 23, 2025 22:57
@tenthirtyam tenthirtyam marked this pull request as ready for review January 24, 2025 17:40
Technical Debt: errcheck

Check the return value to ensure that any issues are caught and handled appropriately.

Signed-off-by: Ryan Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore needs-review Needs Review technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address linting ssues
1 participant