build(deps): Included data job version in vdk-core/src/vdk/internal/builtin_plugins/run/job_input.py #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
s0sharma
changed the title
s0sharma
changed the title
s0sharma
changed the title
s0sharma
changed the title
s0sharma
changed the title
|
@s0sharma thanks for this contribution!!! |
murphp15
reviewed
Jan 8, 2024
| @@ -182,6 +183,9 @@ def get_execution_properties(self) -> dict: | |||
| "pa__job_start_unixtime": str(int(start_time.timestamp())), | |||
| "pa__job_start_ts_expr": f"cast ({start_time.timestamp()} as timestamp)", | |||
| "pa__op_id": self.__statestore.get(CommonStoreKeys.OP_ID), | |||
| "pa__job_version": self.__statestore.get( | |||
There was a problem hiding this comment.
Can you be sure that it is always there?
Is it there even when ppl run a job locally?
|
Hi @s0sharma , would you be able to complete this change? Do you have any questions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of job_input.get_execution_properties(), I added a way to get the data job version.
Now you can see the data job version too.