Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing event manager so it can clear the queue #441

Merged
merged 7 commits into from
Jan 19, 2024
Merged

fixing event manager so it can clear the queue #441

merged 7 commits into from
Jan 19, 2024

Conversation

skirdey
Copy link
Contributor

@skirdey skirdey commented Nov 18, 2023

When running telephonyserver, some calls would not terminate appropriately, incurring high cost in Twilio as they could get stuck for 250 minutes even if they lasted 10 seconds.
This was due to EventsManager not clearing the queue appropriately and stopping Call termination process from completing.

In the logs it would look like this:

  File "/home/ubuntu/venv/lib/python3.10/site-packages/vocode/streaming/streaming_conversation.py", line 687, in terminate
    await self.events_manager.flush()
  File "/home/ubuntu/venv/lib/python3.10/site-packages/vocode/streaming/utils/events_manager.py", line 36, in flush
    await self.handle_event(event)
    TypeError: object NoneType can't be used in 'await' expression

image

it seems like futures fixtures messing up how async definition is handled within the class

@arpagon arpagon requested a review from ajar98 January 19, 2024 01:17
@arpagon arpagon added the bug Something isn't working label Jan 19, 2024
@arpagon arpagon self-assigned this Jan 19, 2024
@ajar98 ajar98 merged commit 262a0ff into vocodedev:main Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants