Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cartesia to use web sockets with continuation #627

Closed

Conversation

rjheeta
Copy link
Contributor

@rjheeta rjheeta commented Jul 11, 2024

No description provided.

@sauhardjain
Copy link
Contributor

sauhardjain commented Jul 16, 2024

@ajar98 @rjheeta my notes on what's missing currently:

  • set up class-level instances for websocket and ctx so that we can reuse these.
  • we want the audio for an entire turn to be "continued" so we should send these on the same ctx with continue_=True. something i'm unclear about: does one turn correspond to one create_speech_uncached call or can one turn be broken up into multiple create_speech_uncached calls?
  • we should maybe create receive and listen tasks that are run concurrently using asyncio.gather. this pattern is shown in our docs
  • await ctx.no_more_inputs should only be called once no more text chunks will be sent to the Cartesia websocket
  • should we be using the InputStreamingSynthesizer class here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants