Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mklive.sh: fix issues with error handling and unmounting pseudofs #365

Merged

Conversation

classabbyamp
Copy link
Member

  • add some error handling to umount_pseudofs
  • disable the trap before running error_out to stop it running multiple times
  • add --one-file-system to ensure that the rm -rf can't screw you

fixes #364

@classabbyamp classabbyamp added the bug Something isn't working label Jan 16, 2024
@classabbyamp classabbyamp added this to the 2024Q1 milestone Jan 18, 2024
@classabbyamp classabbyamp marked this pull request as ready for review February 10, 2024 17:16
- add some error handling to `umount_pseudofs`
- disable the trap before running `error_out` to stop it running multiple times
- add `--one-file-system` to ensure that the `rm -rf` can't screw you

fixes void-linux#364
@classabbyamp classabbyamp force-pushed the global-thermonuclear-war branch from 29502a3 to cc61d71 Compare February 13, 2024 04:09
@classabbyamp classabbyamp merged commit 5558f00 into void-linux:master Feb 15, 2024
@classabbyamp classabbyamp deleted the global-thermonuclear-war branch February 15, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mklive nukes host pseudofs (dev, sys, proc) when interrupted in some circumstances
1 participant