Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: python3-pynitrokey-0.7.3 #52240

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

slymattz
Copy link
Contributor

@slymattz slymattz commented Sep 16, 2024

Testing the changes

  • I tested the changes in this PR: YES
    EDIT 1/10/25: Version 0.7.3 not only requires click-aliases>=1.0.5 but also python3-fido2>=1.2.0 to work.
    Without the latter, it errors out:
Traceback (most recent call last):
  File "/usr/bin/nitropy", line 5, in <module>
    from pynitrokey.cli import main
  File "/usr/lib/python3.13/site-packages/pynitrokey/cli/__init__.py", line 24, in <module>
    from pynitrokey.cli.fido2 import fido2
  File "/usr/lib/python3.13/site-packages/pynitrokey/cli/fido2.py", line 24, in <module>
    from fido2.ctap2.extensions import (
    ...<3 lines>...
    )
ImportError: cannot import name 'HMACGetSecretInput' from 'fido2.ctap2.extensions' (/usr/lib/python3.13/site-packages/fido2/ctap2/extensions.py)

So I updated click-aliases, fido2 and additionally fire. It works properly.

Dependencies

  1. https://github.com/Nitrokey/pynitrokey/blob/master/pyproject.toml
  2. https://github.com/Nitrokey/nitrokey-sdk-py/blob/main/pyproject.toml
  3. https://github.com/Nitrokey/nethsm-sdk-py/blob/main/pyproject.toml

Local build testing

  • I built this PR locally for my native architecture: x86_64-glibc
  • I built this PR locally for these architectures:
    • x86_64-musl
    • armv6l-musl (crossbuild)
    • aarch64-glibc (crossbuild)
    • armv7l-musl (crossbuild)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Sep 17, 2024
@slymattz slymattz force-pushed the nitrokey-0.5.0 branch 2 times, most recently from b5cb62d to 40ca5d3 Compare September 25, 2024 12:09
@slymattz slymattz changed the title New package: python3-pynitrokey-0.5.0 New package: python3-pynitrokey-0.6.0 Sep 25, 2024
@slymattz slymattz force-pushed the nitrokey-0.5.0 branch 4 times, most recently from da2b774 to 0566508 Compare September 29, 2024 15:07
@slymattz slymattz force-pushed the nitrokey-0.5.0 branch 3 times, most recently from 039e690 to 2a94845 Compare December 7, 2024 20:58
@slymattz slymattz changed the title New package: python3-pynitrokey-0.6.0 New package: python3-pynitrokey-0.7.0 Dec 7, 2024
@slymattz slymattz marked this pull request as draft December 12, 2024 14:02
@slymattz slymattz marked this pull request as ready for review December 12, 2024 14:34
@slymattz slymattz marked this pull request as draft December 17, 2024 14:54
@slymattz slymattz force-pushed the nitrokey-0.5.0 branch 4 times, most recently from 4039194 to 4876a3f Compare December 17, 2024 16:02
@slymattz slymattz changed the title New package: python3-pynitrokey-0.7.0 New package: python3-pynitrokey-0.7.1 Dec 17, 2024
@slymattz slymattz force-pushed the nitrokey-0.5.0 branch 2 times, most recently from db79e40 to a8b3690 Compare December 19, 2024 12:43
@slymattz slymattz marked this pull request as ready for review December 21, 2024 22:55
@slymattz slymattz changed the title New package: python3-pynitrokey-0.7.1 New package: python3-pynitrokey-0.7.3 Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants