Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer when set node other resources #3717

Merged

Conversation

TymonLee
Copy link

It is possible that NewNodeInfo(node *v1.Node) in node_info.go received a nil node argument. In this situation, volcano-scheduler will crash because of nil pointer dereference.
b2cfdd32-1e80-4faa-bc2d-7cccf4c16d72

crash

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2024
@Monokaix
Copy link
Member

The method NewGPUDevices below it has already checked node not nil: )

@TymonLee
Copy link
Author

The method NewGPUDevices below it has already checked node not nil: )

But it will return nil and ni.Others[vgpu.DeviceName] will be set "hamivgpu=nil". In such situation, scheduler could also panic if addResource() or subResource() is called.
image

@Monokaix
Copy link
Member

Ok,please sign off your commit.

@TymonLee TymonLee force-pushed the lzt/opensource/fix_vgpu_nil_pointer branch from 64bc303 to 0a0c06d Compare September 29, 2024 01:53
@TymonLee
Copy link
Author

Ok,please sign off your commit.

OK, done.

@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2024
@Monokaix
Copy link
Member

cc @hwdef @lowang-bh

@william-wang
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2024
@volcano-sh-bot volcano-sh-bot merged commit 6bd27a5 into volcano-sh:master Sep 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants