Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix README broken URL #3718

Merged
merged 1 commit into from
Sep 29, 2024
Merged

docs: fix README broken URL #3718

merged 1 commit into from
Sep 29, 2024

Conversation

jasondrogba
Copy link
Contributor

the url on README can not access, replace it with correct one

@volcano-sh-bot
Copy link
Contributor

Welcome @jasondrogba!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2024
@jasondrogba
Copy link
Contributor Author

hi, can you review this PR ~ @k82cn
/assign @k82cn

hwdef
hwdef reviewed Sep 12, 2024
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@volcano-sh-bot volcano-sh-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. labels Sep 12, 2024
@jasondrogba
Copy link
Contributor Author

@hwdef @k82cn hi~ why the workflow is still pending😂

@Monokaix
Copy link
Member

Please rebase master: )

@jasondrogba
fix README broken URL
3ce7226 
Signed-off-by: jasondrogba <[email protected]>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2024
@jasondrogba
Copy link
Contributor Author

Please rebase master: )

Thanks, already rebased : )

@william-wang
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2024
@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2024
@volcano-sh-bot volcano-sh-bot merged commit 9712489 into volcano-sh:master Sep 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

@hwdef hwdef Awaiting requested review from hwdef

Assignees

@hwdef hwdef

@Monokaix Monokaix

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasondrogba @volcano-sh-bot @Monokaix @william-wang @hwdef @k82cn