Don't depend on ready condition of nodes instead of taints in session #3756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/S
Monokaix
changed the title
volcano-sh-bot
added
size/M
Signed-off-by: Monokaix <[email protected]>
|
/lgtm |
hwdef
approved these changes
Oct 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hwdef The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
/ok-to-test |
volcano-sh-bot
added
the
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cni plugin need deployed first then the node can get ready，so we should not filter not ready node in scheduler，instead the node will be tainted by kube controller when node not ready，and pod will not be scheduled by default，also pod can set tolerations to get scheduled.
xref: https://github.com/kubernetes/design-proposals-archive/blob/main/scheduling/taint-node-by-condition.md
previous pr：#507