Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update uninstall-volcano.sh #3938

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update uninstall-volcano.sh #3938

wants to merge 1 commit into from

Conversation

mahmut-Abi
Copy link

helm uninstall will not delete namespace.

@mahmut-Abi
Update uninstall-volcano.sh
82e0519 
helm uninstall will not delete namespace.
@volcano-sh-bot
Copy link
Contributor

Welcome @mahmut-Abi!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hzxuzhonghu
You can assign the PR to them by writing /assign @hzxuzhonghu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 30, 2024
@JesseStutler
Copy link
Member

Hi, please sign your commit by using git commit -s.

By the way, why would you like to use scripts under benchmark to install volcano, are there any performance testing requirements? The script in the benchmark directory is not mature yet.

@JesseStutler
Copy link
Member

JesseStutler commented Dec 30, 2024 •
edited
Loading

/area deploy

@volcano-sh-bot volcano-sh-bot added area/test CI and test related Issues or PRs area/deploy Issues or PRs related to deploy/helm/build/scripts changes labels Dec 30, 2024
@Monokaix
Copy link
Member

Monokaix commented Feb 5, 2025

Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huone1 huone1 Awaiting requested review from huone1

@jasonliu747 jasonliu747 Awaiting requested review from jasonliu747

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/deploy Issues or PRs related to deploy/helm/build/scripts changes area/test CI and test related Issues or PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahmut-Abi @volcano-sh-bot @JesseStutler @Monokaix