Add stronger reward verification sandbox #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vermouth1992
reviewed
Feb 6, 2025
| metadata_list.append({}) | ||
|
|
||
|
|
||
| def check_correctness(in_outs: Optional[dict], generation, timeout=10, debug=True): |
There was a problem hiding this comment.
Could you add a test case to show the usage of this function?
vermouth1992
reviewed
Feb 6, 2025
verl/trainer/main_ppo.py
Outdated
| import asyncio | ||
| from functools import partial | ||
|
|
||
| from tqdm.asyncio import tqdm | ||
|
|
There was a problem hiding this comment.
the ProcessPoolExecutor / asyncio libs are no longer needed in this file
| @@ -142,6 +142,7 @@ reward_model: | |||
| ulysses_sequence_parallel_size: 1 # sp size | |||
| use_dynamic_bsz: ${critic.use_dynamic_bsz} | |||
| forward_max_token_len_per_gpu: ${critic.forward_max_token_len_per_gpu} | |||
| reward_manager: naive | |||
There was a problem hiding this comment.
could you add this option to https://github.com/volcengine/verl/blob/main/docs/examples/config.rst as well? thanks!
eric-haibin-lin
approved these changes
Feb 9, 2025
vermouth1992
changed the title
4 tasks
vermouth1992
pushed a commit
that referenced
this pull request
Feb 10, 2025
Add stronger verification support as is used in https://github.com/PRIME-RL/PRIME - [x] Batched verification - [x] Python interpreter - [x] Stronger math verifier - [x] Continuous score for code test Re-opening #207 to trigger automatic workflows
as12138
pushed a commit
to as12138/verl
that referenced
this pull request
Feb 20, 2025
Add stronger verification support as is used in https://github.com/PRIME-RL/PRIME - [x] Batched verification - [x] Python interpreter - [x] Stronger math verifier - [x] Continuous score for code test Re-opening volcengine#207 to trigger automatic workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stronger verification support as is used in https://github.com/PRIME-RL/PRIME