Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typst_vello: Use Default::default() #11

Merged
merged 1 commit into from
Sep 16, 2024
Merged

typst_vello: Use Default::default() #11

merged 1 commit into from
Sep 16, 2024

Conversation

waywardmonkeys
Copy link
Contributor

This is standard Rust and reduces the dependency on bevy_utils.

@waywardmonkeys
typst_vello: Use Default::default()
d0760fd 
This is standard Rust and reduces the dependency on `bevy_utils`.
@nixon-voxell
Copy link
Member

Agreed, I think we can just remove bevy_utils dependencies altogether by adding hashbrown as a dependency.

@waywardmonkeys waywardmonkeys mentioned this pull request Sep 16, 2024
Merged
@waywardmonkeys
Copy link
Contributor Author

Agreed, I think we can just remove bevy_utils dependencies altogether by adding hashbrown as a dependency.

See #12 :)

@nixon-voxell
Copy link
Member

Thanks!

@nixon-voxell nixon-voxell merged commit fe65285 into voxell-tech:main Sep 16, 2024
7 checks passed
@waywardmonkeys waywardmonkeys deleted the use-Default-default-rather-than-bevy-util branch September 16, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixon-voxell nixon-voxell Awaiting requested review from nixon-voxell nixon-voxell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Velyst
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @nixon-voxell