-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #179 Add tests for empty eyaml values #322
base: master
Are you sure you want to change the base?
Conversation
Unfortunately, when I run
I made the following change: diff --git a/features/support/env.rb b/features/support/env.rb
index 1b3bfc9..5bb9b85 100644
--- a/features/support/env.rb
+++ b/features/support/env.rb
@@ -2,7 +2,7 @@ rubylib = (ENV["RUBYLIB"] || "").split(File::PATH_SEPARATOR)
rubylib.unshift %|#{File.dirname(__FILE__) + '/../../lib'}|
ENV["RUBYLIB"] = rubylib.uniq.join(File::PATH_SEPARATOR)
require 'rubygems'
-require 'aruba/config'
+require 'aruba/configuration'
require 'aruba/cucumber'
require 'fileutils'
require 'pathname' Then I ran
I made an additional change: diff --git a/features/support/env.rb b/features/support/env.rb
index 5bb9b85..226bc38 100644
--- a/features/support/env.rb
+++ b/features/support/env.rb
@@ -26,7 +26,7 @@ end
# ENV['EDITOR']="/bin/cat"
Aruba.configure do |config|
- config.before_cmd do |cmd|
+ config.before(:cmd) do |cmd|
SetupSandbox.create_files test_files
# when executing, resolve the SANDBOX_HOME into a real HOME
ENV['HOME'] = Pathname.new(ENV['SANDBOX_HOME']).realpath.to_s And this time the tests did run, but I got lots of unexpected |
Here's the Cucumber Report: https://reports.cucumber.io/reports/3bce10ce-e653-49cc-8610-b75976b94206 |
I had to close and reopen the PR to trigger github actions |
Tests should have failed. They passed, so either the added tests are inadequate, or the reported bug does not actually exist. |
This PR only contains test changes for #179 and the tests should fail.