Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix file ownerships #602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix file ownerships #602

wants to merge 1 commit into from

Conversation

ceriath
Copy link

@ceriath ceriath commented Jan 7, 2022

Pull Request (PR) description

Currently most exporters have weird permissions after being installed (e.g. 3434:3434 ownership). For the exporters installed via daemon, there is already a patch applied, which sets the owner and group to root:0 for the executables, which still leaves files like "LICENSE" etc. with the wrong ownerships. I am adding a patch for all files, replacing the old patch.

This Pull Request (PR) fixes the following issues

Fixes #111

@ceriath ceriath force-pushed the master branch 6 times, most recently from a85ffd5 to c7af82c Compare January 7, 2022 16:24
@baurmatt
Copy link
Contributor

baurmatt commented Feb 9, 2022

I could only find files like LICENSE, NOTICE, README.md with weird permissions. Those files are irrelevant to the actual exporter functionality. As fixing those permissions requires dirty exec workarounds, could you please elaborate why you think this is important?

@baurmatt
Copy link
Contributor

I've talked about this with @kubicgruenfeld. The best solution for this seems to be the user/group parameter of the archive resource:

-> https://github.com/voxpupuli/puppet-prometheus/blob/873ce7842554b98bfe3e286b1623f6672d637a53/manifests/daemon.pp
-> https://github.com/voxpupuli/puppet-archive/blob/master/REFERENCE.md#user
-> https://github.com/voxpupuli/puppet-archive/blob/master/REFERENCE.md#group

e.g.

archive { "/opt/${name}-${version}.${os}-${arch}/${name}":
  user  => 'root',
  group => 0,
}

Could you please test if this works? :)

@vox-pupuli-tasks
Copy link

Dear @ceriath, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporters unpacked to /opt are not root:root
2 participants