Clone git repository as $user #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of cloning as root and using a file resource to change files ownership to the configured user, directly clone the repository with this user. This fix a warning issued by puppet: Warning: The directory '/srv/puppetboard/puppetboard' contains 1936 entries, which exceeds the default soft limit 1000 Fixes #351
kenyon
approved these changes
Mar 26, 2022
We python module is fragile and automatic detection of the need of running pip install is sometimes broken.
smortex
force-pushed
the
vcsrepo-user
branch
2 times, most recently
from
f7ff1e8
to
ee80856
Compare
smortex
commented
Mar 28, 2022
kenyon
approved these changes
Mar 28, 2022
ekohl
reviewed
Mar 28, 2022
smortex
force-pushed
the
vcsrepo-user
branch
2 times, most recently
from
e57ea72
to
58f4a98
Compare
root-expert
reviewed
Mar 28, 2022
bastelfreak
reviewed
Mar 28, 2022
| @@ -138,7 +138,7 @@ | |||
| vcsrepo { "${basedir}/puppetboard": | |||
| ensure => present, | |||
| provider => git, | |||
| owner => $user, | |||
| user => $user, | |||
There was a problem hiding this comment.
will that break existing installations? was that maybe setup like that on purpose, so the user that runs it has no permissions / less permissions?
There was a problem hiding this comment.
The only case I can see is if the user cannot traverse one of the parent directories.
Because of #349 (review) I would also want to change this user to root:root by default, but this will be a breaking change.
No puppetserver6 / puppetdb6 packages are available for Debian 11.
smortex
force-pushed
the
vcsrepo-user
branch
2 times, most recently
from
50edee9
to
33cc4e6
Compare
ekohl
reviewed
Mar 28, 2022
ekohl
approved these changes
Mar 29, 2022
Comment on lines
+6
to
+9
| return false if ENV['BEAKER_PUPPET_COLLECTION'] == 'puppet6' && host_inventory['facter']['os']['release']['major'] == '11' | ||
| end | ||
|
|
||
| true |
There was a problem hiding this comment.
You can consider this style as well.
Suggested change
| return false if ENV['BEAKER_PUPPET_COLLECTION'] == 'puppet6' && host_inventory['facter']['os']['release']['major'] == '11' | |
| end | |
| true | |
| ENV['BEAKER_PUPPET_COLLECTION'] != 'puppet6' && host_inventory['facter']['os']['release']['major'] != '11' | |
| else | |
| true | |
| end |
There was a problem hiding this comment.
The && should also be changed to || but it feels less readable in my opinion so for now I will merge as is so that other PR can benefit from the fixes for Debian / Ubuntu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of cloning as root and using a file resource to change files
ownership to the configured user, directly clone the repository with
this user.
This fix a warning issued by puppet:
Warning: The directory '/srv/puppetboard/puppetboard' contains 1936 entries, which exceeds the default soft limit 1000
Fixes #351