Deprecate systemd::service_limits
#437
Conversation
|
I thought that should fail on 8- was confused why it didn't locall - sure it used to. |
The `systemd::service_limts` and corresponding type `Systemd::Servicelimits` is deprecated. Switch to `systemd::dropin_file` for a source attributed `systemd::service_limits` or `systemd::manage_unit` for a `limits` attributed `systemd::service_limits`.
|
@traylenator is that actually a breaking change, or does it just prepare it? I would like to do the next major release somewhere in the next weeks and drop also support for EoL/soon-EoL operating systems. |
It just prepares it - should be nothing breaking other than puppet8 rspec tests of course. Had assumed that breaking is when you add the deprecation and then when its actually removed it is not breaking since declared deprecated? |
|
I would say it doesn't break your existing setup, so this could be released as a minor release and when we remove the parameter it's a breaking change. |
|
There's already a breaking change in HEAD however - #438 ? Ship has sailed. |
|
I would be nice if we could get #406, #429, #437 and #443 done and make a major release, plus the proposed drop for EOL/soon-EOL from @bastelfreak? And hope @traylenator doesn't come up with another breaking feature with 1-2 weeks :D |
|
There is also #434 which is already merged |
Yeah. I've had to change (bad) code due to this one. |
`systemd::service_limits` was deprecated voxpupuli/puppet-systemd#437
Pull Request (PR) description
The
systemd::service_limitsand corresponding typeSystemd::Servicelimitsis deprecated.Switch to
systemd::dropin_filefor a source attributedsystemd::service_limitsorsystemd::manage_unitfor alimitsattributedsystemd::service_limits.