Allow $ in treetop parsed strings.
#241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Treetop was also failing one a line similar too: Adding Please let me know if this can be pulled into master. |
|
Is there any chance this is related to #215 which is using the # character ? edit: adding # to the allowed characters does indeed resolve this issue. I've opened kwolf-zz#1 in the hopes it can get included - if not no worries i'll open a new one here. |
Update jboss_cli.treetop
|
Merged the |
|
I don't think that last failure was related to the code change. |
|
@biemond any update on possibly merging my three PR's? This is the most important one. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of upgrading from Puppet 3 to 4 and using this as an opportunity to upgrade to the latest wildfly module as well.
I had some parsing problems with Treetop, and the only ones I couldn't fix on our side were strings that had
$in them. I tried quoting them, escaping them everything I could think of but couldn't get it to pass Treetop's validation.This PR allows dollar signs. I'd love to get this accepted... this is the only real reason we'll have to run our fork.
The strings I had issue with are:
/subsystem=logging/logger=com.company.common.services.DefaultCompanyPoolExecutor$UserBasedCallable:dummy /subsystem=logging/logger=com.company.common.services.DefaultCompanyThreadPoolExecutor$UserBasedRunnable:dummyI tried this all the way up to master of the Puppet module. If I'm missing something and need to escape this differently or in a way I haven't though of, please let me know.