fix: security vulnerability SSRF (#256)

vran-dev · Jul 29, 2022 · 226c20e · 226c20e
1 parent 4df8f9b
commit 226c20e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/core/src/main/java/com/databasir/core/infrastructure/driver/DriverResources.java b/core/src/main/java/com/databasir/core/infrastructure/driver/DriverResources.java
@@ -60,7 +60,7 @@ private File download(String driverFileUrl, String parentDir) {
         try {
             Files.createDirectories(parentDirPath);
         } catch (IOException e) {
-            log.error("下载驱动时创建目录失败", e);
+            log.error("create directory for driver failed", e);
             throw DomainErrors.DOWNLOAD_DRIVER_ERROR.exception(e);
         }
 
@@ -97,8 +97,9 @@ private File download(String driverFileUrl, String parentDir) {
                 }
             });
         } catch (RestClientException e) {
-            log.error(parentDir + " download driver error", e);
-            throw DomainErrors.DOWNLOAD_DRIVER_ERROR.exception(e.getMessage());
+            String msg = String.format("download driver from %s to %s failed", driverFileUrl, parentDir);
+            log.error(msg, e);
+            throw DomainErrors.DOWNLOAD_DRIVER_ERROR.exception(msg);
         }
     }